Rework time-driver contract. #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
refactor
branch
5 times, most recently
from
62e07f4 to
9c8b89e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bugadani
force-pushed
the
refactor
branch
3 times, most recently
from
c5439bf to
21dff6a
Compare
bugadani
force-pushed
the
refactor
branch
9 times, most recently
from
9e23362 to
97cfa4f
Compare
bugadani
force-pushed
the
refactor
branch
3 times, most recently
from
3c048c9 to
efdddc3
Compare
bugadani
force-pushed
the
refactor
branch
2 times, most recently
from
7c66671 to
9733969
Compare
bugadani
force-pushed
the
refactor
branch
4 times, most recently
from
640bd1c to
2474fbf
Compare
|
bender run |
bugadani
force-pushed
the
refactor
branch
2 times, most recently
from
ec73c78 to
1401572
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bugadani
force-pushed
the
refactor
branch
4 times, most recently
from
9b4fbde to
01b2f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the contract between embassy-time-driver and implementations to a pair of
nowandschedule_wakefunctions. Implementing a timer queue is now the responsibility of the time-driver implementation, the generic-queue or integrated-timer features no longer provide a complete implementation, it's now the responsibility of the time-driver/timer-queue-driver implementor.If using the executor, integrated-timers are implied, but the users may choose
_generic-queueif they want to.Companion changes in esp-hal: esp-rs/esp-hal#2701