Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing opamp external outputs for STM32G4 #3636

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

G-Levine
Copy link
Contributor

This PR adds the ability to use following opamp/ADC combinations when the opamp is configured in external output mode.
These are documented in the STM32G4 reference manual but currently missing in Embassy.

  • OPAMP3 with ADC1 (output pin is PB1)
  • OPAMP4 with ADC1 (output pin is PB12)
  • OPAMP6 with ADC2 (output pin is PB11)
Screenshot 2024-12-07 at 8 55 54 PM

@Dirbaio
Copy link
Member

Dirbaio commented Dec 11, 2024

bender run

@G-Levine
Copy link
Contributor Author

Any idea what caused this CI failure?

+ git clone -n https://github.com/G-Levine/embassy.git code Cloning into 'code'... error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8) error: 4178 bytes of body are still expected fetch-pack: unexpected disconnect while reading sideband packet fatal: early EOF fatal: fetch-pack: invalid index-pack output run failed: exited with code 128

@Dirbaio
Copy link
Member

Dirbaio commented Dec 13, 2024

flaky networking. retrying

bender run

@Dirbaio Dirbaio enabled auto-merge December 13, 2024 11:20
@Dirbaio Dirbaio added this pull request to the merge queue Dec 13, 2024
Merged via the queue into embassy-rs:main with commit 45d9bd5 Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants