Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usb composite iads by default #3682

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

Eekle
Copy link
Contributor

@Eekle Eekle commented Dec 24, 2024

Sets the USB stack to use the "Composite with IADs" profile by default. This is the most "just works" configuration available.

Without this, using the default config and adding - for example - the CDC-ACM class will fail initialisation on Windows due to mismatched class identifiers.

@Eekle Eekle changed the title Usb composite iars by default Usb composite iads by default Dec 24, 2024
device_protocol: 0x00,
device_class: 0xEF,
device_sub_class: 0x02,
device_protocol: 0x01,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need updating the default in the docs as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thakns!

@Dirbaio Dirbaio added this pull request to the merge queue Dec 24, 2024
Merged via the queue into embassy-rs:main with commit 2c87b31 Dec 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants