Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embassy-net: when std is set enable smoltcp/std #3683

Closed
wants to merge 1 commit into from

Conversation

dpeckett
Copy link

@dpeckett dpeckett commented Dec 25, 2024

As explained in the title, this is mostly to solve some clippy issues with ManagedSlice's I've been running into.

@Dirbaio
Copy link
Member

Dirbaio commented Dec 25, 2024

nothing in embassy-net requires smoltcp apis that are only available under std, so it's not possible that this fixes any issues.

The problem with smoltcp+managed you're encountering is typically due to something enabling managed/std or managed/alloc behind smoltcp's back so they get out of sync. Check which crate it is with cargo tree --format '{p} {f}' and remove it, and you'll find everything builds.

@dpeckett
Copy link
Author

Thanks @Dirbaio, you were of course right. the managed crate was getting pulled in elsewhere.

@dpeckett dpeckett closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants