Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of ember-cli ui instance #1030

Merged

Conversation

bertdeblock
Copy link
Member

Part of decoupling ember-try from ember-cli.

@bertdeblock bertdeblock self-assigned this Dec 17, 2024
@bertdeblock bertdeblock changed the title Remove use of Ember CLI's ui instance Remove use of ember-cli ui instance Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.55%. Comparing base (762ca35) to head (89aa730).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/tasks/try-each.js 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1030      +/-   ##
==========================================
+ Coverage   95.44%   95.55%   +0.11%     
==========================================
  Files          21       22       +1     
  Lines         505      518      +13     
==========================================
+ Hits          482      495      +13     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bertdeblock bertdeblock merged commit 8f8be97 into ember-cli:main Dec 18, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants