Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use ember-cli project instance outside of ember-cli commands #1036

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bertdeblock
Copy link
Member

@bertdeblock bertdeblock commented Dec 18, 2024

Part of decoupling ember-try from ember-cli.

This way, only the code in lib/commands is coupled to ember-cli.
The next step would be to move the run portion of the commands to separate files.
This would allow us to move everything to ES modules, except the commands.
The commands can async import and run the ES modules.

@bertdeblock bertdeblock self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (d3b56f1) to head (f747ca7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
- Coverage   95.49%   95.10%   -0.40%     
==========================================
  Files          21       21              
  Lines         511      511              
==========================================
- Hits          488      486       -2     
- Misses         23       25       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bertdeblock
Copy link
Member Author

Still need to update getting the config without a project instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants