Don't use ember-cli project
instance outside of ember-cli commands
#1036
+33
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of decoupling
ember-try
fromember-cli
.This way, only the code in
lib/commands
is coupled toember-cli
.The next step would be to move the
run
portion of the commands to separate files.This would allow us to move everything to ES modules, except the commands.
The commands can async import and run the ES modules.