Remove use of core-object for tasks
#999
Merged
+64
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
force-pushed
the
remove-use-of-core-object
branch
from
4f97e8e to
2442cec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
+ Coverage 94.75% 94.81% +0.05%
==========================================
Files 18 18
Lines 534 540 +6
==========================================
+ Hits 506 512 +6
Misses 28 28 ☔ View full report in Codecov by Sentry. |
bertdeblock
force-pushed
the
remove-use-of-core-object
branch
from
2442cec to
42da696
Compare
bertdeblock
changed the title
core-objectcore-object for tasks
bertdeblock
commented
Dec 10, 2024
| @@ -10,7 +10,6 @@ module.exports = { | |||
| let ResetTask = require('../tasks/reset'); | |||
|
|
|||
| let resetTask = new ResetTask({ | |||
| ui: this.ui, | |||
There was a problem hiding this comment.
Not used in ResetTask.
bertdeblock
commented
Dec 10, 2024
| run() { | ||
| let dependencyAdapters = | ||
| this.dependencyManagerAdapters || |
There was a problem hiding this comment.
dependencyManagerAdapters is never passed in as an option for the reset task, so removed it here for now.
bertdeblock
force-pushed
the
remove-use-of-core-object
branch
from
42da696 to
819a6d5
Compare
kategengler
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will make follow-up PRs for the rest, don't want these to get too big.