Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace term whitelist with allowlist #806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcfiredrill
Copy link

I followed the RFC from awhile back that has since been merged, so
hopefully this can be changed here in ember-cli-fastboot as well.

I followed the RFC from awhile back that has since been merged, so
hopefully this can be changed here in ember-cli-fastboot as well.
@kiwiupover
Copy link
Member

@mcfiredrill thank you so much for your PR. I really want to make sure that we land it soon.

To fix the test failures we there needs to be an update to the underlying fastboot module. You can see that here: https://github.com/ember-fastboot/fastboot/search?q=whitelist

We are in the process of pulling all the fastboot packages together into one repo which will make this PR much easier to land. Once #805 is merge then this PR will be very easy to make the change across all the fastboot packages.

@mcfiredrill
Copy link
Author

Great thank you! Sorry I didn't have time to look into the test failures yet.

To fix the test failures we there needs to be an update to the underlying fastboot module. You can see that here: https://github.com/ember-fastboot/fastboot/search?q=whitelist

Makes sense.
Is it worth making a PR to ember-fastboot to fix , or maybe it's better to wait until the monorepo is setup?

@kiwiupover
Copy link
Member

@mcfiredrill Hello we just merged the monorepo branch please feel free to update your PR.

We would like to use the name allowedHosts going forward. Does that make sense?

Thanks for your help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants