Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implicit injection deprecation #1075

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix implicit injection deprecation #1075

merged 1 commit into from
Jan 8, 2024

Conversation

simonihmig
Copy link
Contributor

@netlify Netlify
Copy link

netlify bot commented Jan 7, 2024 •
edited
Loading

✅ Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit f5a689b
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/659b1c347d34ed00082e332f
😎 Deploy Preview https://deploy-preview-1075--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mansona
mansona approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@mansona mansona merged commit 84599c7 into ember-learn:main Jan 8, 2024
6 checks passed
@simonihmig simonihmig deleted the fix-3x-deprecations branch January 8, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

@gilest gilest gilest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonihmig @gilest @mansona