Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ember-data-fastboot to enable the shoebox across the site #1120

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

mansona
Copy link
Member

@mansona mansona commented Jul 22, 2024

This now prevents the first load of data on each page that has been pre-rendered with fastboot and prember 👍

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 86225db
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/669e8a59db798f0008662855
😎 Deploy Preview https://deploy-preview-1120--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mansona mansona requested a review from a team July 22, 2024 16:36
@@ -58,6 +58,7 @@
"ember-cli-terser": "^4.0.2",
"ember-composable-helpers": "^5.0.0",
"ember-data": "~3.28.0",
"ember-data-fastboot": "github:cardstack/ember-data-fastboot",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about this package - that's neat.

Copy link

2/14 Files got Bigger 🚨:

Details
File raw gzip
ember-website.js +524 B +133 B
ember-website-fastboot.js +963 B +404 B

12/14 Files stayed the same size 🤷‍:

Details
File raw gzip
blurhash.js 0 B 0 B
chunk.143.js 0 B -1 B
chunk.177.js 0 B 0 B
chunk.178.js 0 B 0 B
chunk.208.js 0 B 0 B
chunk.488.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B 0 B

Created by ember-asset-size-action

@mansona mansona merged commit 7fc181c into main Jul 22, 2024
6 of 7 checks passed
@mansona mansona deleted the shoebox branch July 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants