Skip to content

Commit

Permalink
Merge branch 'master' into super-rentals-tutorial
Browse files Browse the repository at this point in the history
  • Loading branch information
ef4 authored Nov 7, 2024
2 parents 8e1f674 + 1ebccdd commit e3b86fe
Show file tree
Hide file tree
Showing 8 changed files with 17,624 additions and 36,936 deletions.
24 changes: 24 additions & 0 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Setup node and pnpm
description: Setup node and install dependencies using pnpm
inputs:
use_lockfile:
description: 'Whether to use the lockfile vs latest floating dependencies'
required: false
default: 'true'
use_pinned_node:
description: 'Whether to use the node version defined in .npmrc'
required: false
default: 'false'
runs:
using: 'composite'
steps:
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
run_install: false
- uses: actions/setup-node@v4
with:
node-version: 20
cache: pnpm
- run: pnpm install ${{ fromJSON('{"false":"--no-lockfile", "true":"--frozen-lockfile"}')[inputs.use_lockfile] }}
shell: bash
46 changes: 9 additions & 37 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ on:
pull_request:

env:
NODE_VERSION: 20
NODE_OPTIONS: '--max_old_space_size=4096'

jobs:
Expand All @@ -17,41 +16,23 @@ jobs:
timeout-minutes: 7
steps:
- name: Check out a copy of the repo
uses: actions/checkout@v3

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}

- run: npm i -g npm@9
- run: npm ci

uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: Lint
run: npm run lint
run: pnpm run lint

test-app:
name: Test app
runs-on: ubuntu-latest
timeout-minutes: 7
steps:
- name: Check out a copy of the repo
uses: actions/checkout@v3

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}

- run: npm i -g npm@9
- run: npm ci

uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: Test
uses: percy/exec-action@v0.3.1
with:
custom-command: npm run test:ember
custom-command: pnpm run test:ember
env:
PERCY_TOKEN: 877df6aad8486060f69a34864b6cd33f870633743b23411343737c46a875a762

Expand All @@ -61,16 +42,7 @@ jobs:
timeout-minutes: 7
steps:
- name: Check out a copy of the repo
uses: actions/checkout@v2

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}

- run: npm i -g npm@9
- run: npm ci

uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: Test
run: npm run test:node
run: pnpm run test:node
3 changes: 0 additions & 3 deletions guides/release/configuring-ember/handling-deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ export function initialize() {
export default { initialize };
```

The deprecation handler API was released in Ember 2.1.
If you would like to leverage this API in a prior release of Ember you can install the [ember-debug-handlers-polyfill](http://emberobserver.com/addons/ember-debug-handlers-polyfill) addon into your project.

## Deprecation Workflow

Once you've removed deprecations that you may not need to immediately address, you may still be left with many deprecations.
Expand Down
2 changes: 0 additions & 2 deletions guides/release/ember-inspector/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ list of sources for each deprecation. If you are using Chrome or Firefox,
clicking on the source opens the sources panel and takes you to
the code that caused the deprecation message to be displayed.

<img src="/images/guides/ember-inspector/v4.3.4/deprecations-source.png" />

<img src="/images/guides/ember-inspector/v4.3.4/deprecations-sources-panel.png" width="680"/>

You can send the deprecation message's stack trace to the
Expand Down
Loading

0 comments on commit e3b86fe

Please sign in to comment.