Update block-content.md [Named blocks] #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for named blocks
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
elwayman02
reviewed
Aug 24, 2023
elwayman02
reviewed
Aug 24, 2023
elwayman02
reviewed
Aug 24, 2023
elwayman02
reviewed
Aug 24, 2023
Co-authored-by: Jordan Hawker <hawker.jordan@gmail.com>
IgnaceMaes
reviewed
Apr 17, 2024
IgnaceMaes
reviewed
Apr 17, 2024
IgnaceMaes
reviewed
Apr 17, 2024
IgnaceMaes
reviewed
Apr 17, 2024
IgnaceMaes
reviewed
Apr 17, 2024
There was a problem hiding this comment.
This is GREAT!
I reviewed the other linked PR first but my suggestions there would basically mean writing something like this. The code examples make a lot of sense.
I've put a couple of suggestions. If those are resolved this is good to merge.
Sorry you had to wait so long for a review, that's not ideal.
IgnaceMaes
approved these changes
Apr 18, 2024
This was referenced Apr 18, 2024
|
No worries! And you're welcome 😃 I'm glad it got merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aaah, I just saw #1894, I hope it's still ok! Some people requested more documentation about named blocks, so here's another proposition 😃