-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: install latest guidemaker-ember-template
to switch to shiki
#1997
Conversation
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidemaker-ember-template
to switch to shikijiguidemaker-ember-template
to switch to shiki
2b5df82
to
e5a5947
Compare
The breaking change since converting guidemaker and dependencies to a v2 addon is the Ember Data integration. When switching a version via the dropdown it logs:
In @mansona IIRC there were some Ember Data reexport magic in the v1 addon that were changed. Do you have an idea how to proceed here? |
Upgrading to the latest Should be ready to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guidemaker
andguidemaker-ember-template
versionPreview: https://deploy-preview-1997--ember-guides.netlify.app/release/routing/defining-your-routes/