Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: lighten up backtick code #2034

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

IgnaceMaes
Copy link
Member

@IgnaceMaes IgnaceMaes commented Jun 13, 2024

Small tweak to make the inline code backticks more readable and easier to scan on the page.

Before After
before after

PR to include in styleguide: ember-learn/ember-styleguide#511

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit a5272ba
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/667bdcc876783b00083a5cd0
😎 Deploy Preview https://deploy-preview-2034--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IgnaceMaes IgnaceMaes marked this pull request as ready for review June 13, 2024 15:53
@MinThaMie MinThaMie force-pushed the code-backtick-style branch from 013fc89 to a5272ba Compare June 26, 2024 09:17
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you promised to clean it up :)

@MinThaMie MinThaMie merged commit 7c3db1a into ember-learn:master Jun 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants