Skip to content

Commit

Permalink
Pin Ubuntu to 22 for firefox tests
Browse files Browse the repository at this point in the history
browser-actions/setup-firefox#622
(cherry picked from commit 22474b5)
  • Loading branch information
kategengler committed Jan 18, 2025
1 parent cca18a6 commit 0864528
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ runs:
# See https://github.com/puppeteer/puppeteer/issues/12818 "No usable sandbox!"
# this is taken from the solution used in Puppeteer's own CI: https://github.com/puppeteer/puppeteer/pull/13196
# The alternative is to pin Ubuntu 22 or to use aa-exec to disable AppArmor for commands that need Puppeteer.
# This is also suggested by Chromium https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md
run: echo 0 | sudo tee /proc/sys/kernel/apparmor_restrict_unprivileged_userns
shell: bash

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ jobs:

browser-test:
name: Browser Tests (Firefox)
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # Firefox is not installing on Ubuntu 24 on GitHub Actions https://github.com/browser-actions/setup-firefox/issues/622
needs: [basic-test, lint, types]
steps:
- uses: actions/checkout@v4
Expand Down

0 comments on commit 0864528

Please sign in to comment.