-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TIME type conversion to string converter #168
add TIME type conversion to string converter #168
Conversation
@hiroyuki-sato |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@p-eye Could you check my comments? (Thank you for proposing PR.)
28fdc3a
to
563872b
Compare
563872b
to
8eaab04
Compare
This is exactly what I need. I'm waiting for it to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll approve after removing trailing spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@p-eye LGTM 👍 Thanks! @joker1007 Could you take a look when you get a chance?
hi, any updates? 😃 |
@p-eye I pinged reviewer. The maintainer will review it soon. Please wait a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand. LGTM.
Thanks! |
@p-eye , @dp-daesung |
The converter for converting STRING to DATE type is working well,
but while converting a STRING to TIME type, an error occurred because a converter for this type does not exist. The error message is
(NotSupportedType) cannot take column type TIME for string column.
To fix this, I have added a converter to transform STRING type into BigQuery TIME type. I only updated the string_converter since the format "%H:%M:%S.%6N" is not compatible with the TIMESTAMP type, so I did not modify the timestamp_converter.
--- my bigquery table ---
--- works well with DATE column ---
--- not works with TIME column ---