Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Asset and Release models for Github #404

Merged
merged 24 commits into from
Nov 16, 2024
Merged

Add Asset and Release models for Github #404

merged 24 commits into from
Nov 16, 2024

Conversation

emcek
Copy link
Owner

@emcek emcek commented Nov 9, 2024 •
edited
Loading

Description

Add Asset and Release models for Github

Todo

  • Tests

Related PR and issues

@emcek emcek added the internal Internal changes label Nov 9, 2024
@emcek emcek added this to the Release 3.x milestone Nov 9, 2024
@emcek emcek self-assigned this Nov 9, 2024
@emcek emcek linked an issue Nov 9, 2024 that may be closed by this pull request
Improve ReleaseInfo model #402
Closed
@coveralls
Copy link

coveralls commented Nov 9, 2024 •
edited
Loading

Coverage Status

coverage: 96.072% (+0.07%) from 96.004%
when pulling c4ab281 on releaseinfo_model
into e159e33 on master.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #404 will not alter performance

Comparing releaseinfo_model (c4ab281) with master (db3e315)

Summary

✅ 357 untouched benchmarks

emcek and others added 16 commits November 9, 2024 12:15
@emcek
add test json file
223925a
@emcek
remove double imports
282cac2
@emcek
add default parameter
5bfc9c5
@emcek
use Release model in check_ver_at_github()
9d7897d
@emcek
update tests of get_version_string() and check_ver_at_github()
869b924
@emcek
Merge branch 'master' into releaseinfo_model
4079804
@emcek
make extension with default value
a16f9cd
@emcek
extend Release model
9c4abcd
@emcek
add docstring to Release model property
f0ecb7e
@emcek
fix typing in docstrings
7842d71
@emcek
remove ReleaseInfo and use Release model, fix and update unit tests
5f11f43
@emcek
allow string or Version object as current_ver parameter
afc7e49
@emcek
remove asset_file from Release model and add tests
9bcbd25
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8a3dad5 
for more information, see https://pre-commit.ci
@emcek
fix Exception handling in check_ver_at_github() and in GUI for BIOS c…
262253d 
…hecking
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3894a7b 
for more information, see https://pre-commit.ci
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
70.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
69.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@emcek emcek merged commit a4cb2ac into master Nov 16, 2024
36 checks passed
@emcek emcek deleted the releaseinfo_model branch November 16, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emcek emcek

Labels
internal Internal changes
Projects
None yet
Milestone
Release 3.x
Development

Successfully merging this pull request may close these issues.

Improve ReleaseInfo model
2 participants
@emcek @coveralls