-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous inter-point constraints #345
Open
AVHopp
wants to merge
47
commits into
main
Choose a base branch
from
feature/interpoint_constraints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+497
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
AVHopp
force-pushed
the
feature/interpoint_constraints
branch
from
September 18, 2024 11:47
a5ed090
to
7cbb490
Compare
AVHopp
removed
the
on hold
PR progress is awaiting for something else to continue
label
Sep 18, 2024
AVHopp
commented
Sep 18, 2024
AVHopp
force-pushed
the
feature/interpoint_constraints
branch
from
September 27, 2024 13:51
7cbb490
to
d5758c5
Compare
AVHopp
commented
Sep 27, 2024
AVHopp
force-pushed
the
feature/interpoint_constraints
branch
from
October 22, 2024 10:58
d5758c5
to
ecb050e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
AVHopp
force-pushed
the
feature/interpoint_constraints
branch
2 times, most recently
from
November 11, 2024 17:02
1e2cd40
to
004ec49
Compare
Scienfitz
requested changes
Nov 15, 2024
Scienfitz
requested changes
Nov 15, 2024
AVHopp
force-pushed
the
feature/interpoint_constraints
branch
4 times, most recently
from
November 20, 2024 15:11
c79d2f0
to
38e9571
Compare
Scienfitz
reviewed
Nov 22, 2024
Scienfitz
reviewed
Nov 22, 2024
AVHopp
force-pushed
the
feature/interpoint_constraints
branch
from
January 14, 2025 13:03
abee721
to
2b8d314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a first variant of inter-point constraints by using the
botorch
-provided interface.Here, an inter-point constraint is a constraint that acts on a full batch instead of a single recommendation. If we think of a batch recommendation of a matrix with shape
batches x features
, then our previous constraints would be row-wise, while these constraints allow mixed constraints across both dimensions.This PR introduces new classes, and these classes were modeled similar to the already existing classes for continuous constraints. Some things had to be changed though resp. we need to aware:
get_polytope_samples
is not made for including inter-point constraints, and hence a workaround was implemented. The workaround basically transforms the space in a one-dimensional space withbatches * features
many features, and then defines both normal and inter-point constraints over this space (see [Bug]get_polytope_samples
fails for inequalities overq
-batches and the actual dimension pytorch/botorch#2468). Note that this might interfere with Botorch with cardinality constraint via sampling #301 and that some alignment might be necessary.