Major refactor to be consistent with cogent core coding principles #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no more huge monolithic interfaces - only have methods that actually need to be defined in algorithm-specific code, and use Base types for basic common data and methods that applies to everything.
this avoids name conflicts between interface and struct, so now .Name is the field, and there is no Name() method.
move basic infrastructure stuff from axon into emer base classes, so it doesn't need to be rewritten. need to do more on this with weights and params methods, but basic stuff is in place.
only include minimal method set to support netview, io (weights), and params: no Build() etc. and use Emer* specific names to avoid conflicts with "native" algorithm-specific accessors where relevant.