Add ability to show/hide event types in Events list in viz #60
Conversation
emichael
added
enhancement
|
@wilcoxjay is this what you had in mind for #59?
I'm just now realizing you might have meant the list on the right side of the window. What sort of UI were you thinking? |
emichael
force-pushed
the
feature/message-timer-visibility
branch
2 times, most recently
from
b75d798
to
59213bf
Compare
|
Ah, yeah, I actually meant the right-hand pane. The use case is a failing random DFS search trace that is like 50 messages long and most of them are Pings I don't care about :) |
|
Ahhhh, gotcha. Any ideas for the UI for setting the filters? Should this be in the left side pane like I have these settings or maybe a pop up menu with something similar (and where would you open the pop up menu)? |
|
I think the simplest thing is just more checkboxes on the far left. |
emichael
force-pushed
the
feature/message-timer-visibility
branch
from
59213bf
to
e70bfd4
Compare
|
Okay, I think this implementation makes sense now. @wilcoxjay want to try it out and kick the tires on it? |
Adds a toggle pane to the left side of the viz that shows/hides events in the Events pane the right side. The current event is never hidden. The toggle pane is updated as new event types are encountered. Fixes #59.
emichael
force-pushed
the
feature/message-timer-visibility
branch
from
e70bfd4
to
a5e7eea
Compare
emichael
changed the title
emichael
changed the title
|
Looks good to me! If you try to filter out an event that matches the current state you're looking at, then it is not filtered but still shown. But I think this is probably good behavior anyway. |
|
Yes, that was intentional. Alright, cool. I'll merge this. Let me know how it works and if people find it useful |
Adds a toggle pane to the left side of the viz that shows/hides events in the Events pane the right side. The current event is never hidden. The toggle pane is updated as new event types are encountered. Fixes emichael#59.
Adds a toggle pane on the side that shows/hides the messages in each node's inbox area.
This commit might address #59, but I'm not sure.