Add java.time to list of allowed reflective accesses #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered from a student reporting spurious
--checks
warning about fast cloning andClientWorker
:Tracked it down by unswallowing the underlying exception to discover:
This pointed to an "illegal" reflective access.
Adding another
--add-opens
fixes it, but we need to add it in three places:run-tests.py
I believe this was introduced in the recent refactor of ClientWorker to support better timing information, using
java.time.Instant
as a field, which we had apparently never used in dslabs before (or at least not in a place that the cloning library needed to touch).There is a separate question of why we are even trying to clone that Instant (either it's a run test, in which case we shouldn't be cloning nodes, or it's a search test, in which case we shouldn't be looking at the clock at all), but I'm ignoring that for now.