Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oom_score_adj Process methods #298

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

futpib
Copy link
Contributor

@futpib futpib commented Jan 10, 2024

I took note of this comment: #139 (review):

So the way I read this is: while the final OOM "score" will be somewhere between 0 and 1000, the value reported in oom_score_adj can be between -1000 and 1000. So I think the oom_score_adj function should return a i16 not u32.

And changed oom_score type to u16 too, since it too only ranges from 0 to 1000.

Previous attempt: #139

@eminence
Copy link
Owner

eminence commented Feb 3, 2024

LGTM, thanks!

@eminence eminence merged commit a8bda9e into eminence:master Feb 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants