Skip to content

Commit

Permalink
Remove rust improvement section
Browse files Browse the repository at this point in the history
Copying the data does not really dominate the
run-time of assembling/disassembling.
  • Loading branch information
stuxnot committed Oct 18, 2023
1 parent 47603c8 commit 2cb1c0c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions bindings/rust/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ fn main() -> Result<()> {

The nyxstone-rs bindings are generated via the `cxx` crate. Since nyxstone is specifically a c++ library, we currently do not plan to support C bindings via bindgen.

## Future improvements

The binding class `NyxstoneFFI` currently copies a lot of data between the rust and c++ code. It would be more efficient to not copy data which is only read inside the c++ code.

## Acknowledgements

The build script of the rust bindings borrow heavily from the [llvm-sys](https://gitlab.com/taricorp/llvm-sys.rs) build script.

0 comments on commit 2cb1c0c

Please sign in to comment.