Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor according to some internal and external recommendations #35

Merged
merged 9 commits into from
Oct 27, 2023
Merged

Refactor according to some internal and external recommendations #35

merged 9 commits into from
Oct 27, 2023

Conversation

stuxnot
Copy link
Collaborator

@stuxnot stuxnot commented Oct 25, 2023

Mainly cleans up the c++ code a bit:

  • Adds a emproof namespace
  • Removes usages of std::endl in favor of '\n'
  • Moves the public members of nyxstone up, so that they are the first thing you see
  • Tries to improve readibility by
    1. cleaning up assemble_impl
    2. Using a better clang format style

@stuxnot
Adds emproof namespace
742d6eb
@stuxnot
Removes std::endl
997ac4a
@stuxnot
Changes order of private and public nyxstone members
4c1dd66 
For better readibility, this commit moves the private members of
nyxstone below the public member functions.

It furthermore removes the unnecessary members cpu and features, which
the nyxstone class does not need.
@stuxnot
Explains uint8_t for IntegerBase
3b060e9
@stuxnot
Moves bkpt prepend/remove to functions
494b101 
Creates functions for bkpt prepension and removal, so that the
`assemble_impl` is easier to understand.
@stuxnot
Use WebKit clang-format style
e6e35e8
@stuxnot
Merge branch 'main' into refactor/external-recommendations
c877c09
@stuxnot
Rename namespace to nyxstone
a734d05
@stuxnot
Use namespace in pybindings
09a9b9d
@stuxnot stuxnot changed the title Draft: Refactor according to some internal and external recommendations Refactor according to some internal and external recommendations Oct 27, 2023
@pkoppe pkoppe merged commit 78fd158 into main Oct 27, 2023
4 checks passed
@pkoppe pkoppe deleted the refactor/external-recommendations branch October 27, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuxnot @pkoppe