Skip to content

Commit

Permalink
fix: Don't assume shortnames
Browse files Browse the repository at this point in the history
  • Loading branch information
ieQu1 committed Jun 30, 2023
1 parent 202f021 commit 05ecf0a
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 7 deletions.
16 changes: 14 additions & 2 deletions doc/src/schema.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,18 @@ Autorate configuration can be referred by id.
This scenario starts `-N` workers, which subscribe to a specified topic.
The only mandatory parameter is `--topic`, which supports pattern substitutions.

[id=scenarios.sub._.parse_metadata]
== Extract metadata from message payloads

Subscribers will report end-to-end latency when this option is enabled.

WARNING: Publishers should insert metadata into the payloads.
For example, when using <<value.scenarios.pub,pub scenario>> it's necessary to enable <<value.scenarios.pub._.metadata,metadata>> generation.

WARNING: In order to measure latency accurately, the scenario should ensure that publishers reside on the same emqttb host with the subscribers.
Otherwise clock skew between different load generator instances will introduce a systematic error.


=== Client groups

- `sub`
Expand Down Expand Up @@ -219,13 +231,13 @@ Please note that throughput measurement is not reliable when the consume stage i
[id=scenarios.persistent_session._.pub.qos]
== QoS of the published messages

Warning: changing QoS to any value other then 2 is likely to cause consume stage to hang,
WARNING: changing QoS to any value other then 2 is likely to cause consume stage to hang,
since it has to consume the exact number of messages as previously produced.

[id=scenarios.persistent_session._.sub.qos]
== Subscription QoS

Warning: changing QoS to any value other then 2 is likely to cause consume stage to hang,
WARNING: changing QoS to any value other then 2 is likely to cause consume stage to hang,
since it has to consume the exact number of messages as previously produced.

[id=groups]
Expand Down
2 changes: 0 additions & 2 deletions src/conf/emqttb_conf_model.erl
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
-include("emqttb.hrl").
-include_lib("typerefl/include/types.hrl").

-import(lee_doc, [p/1, li/2]).

%%================================================================================
%% Type declarations
%%================================================================================
Expand Down
2 changes: 1 addition & 1 deletion src/framework/emqttb_app.erl
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ maybe_start_distr() ->
ok;
Name ->
os:cmd("epmd -daemon"),
Opts = #{dist_listen => true, name_domain => shortnames},
Opts = #{dist_listen => true},
net_kernel:start(Name, Opts)
end.
3 changes: 1 addition & 2 deletions src/scenarios/emqttb_scenario_sub.erl
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,7 @@ model() ->
}}
, parse_metadata =>
{[value, cli_param],
#{ oneliner => "Extract metadata from message payloads"
, type => boolean()
#{ type => boolean()
, default => false
, cli_operand => "parse-metadata"
}}
Expand Down

0 comments on commit 05ecf0a

Please sign in to comment.