-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new acceptor reads new listener config #327
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
dev/william/dyn-acceptors
branch
from
December 10, 2024 12:33
44064b0
to
363b40c
Compare
- remove QUIC_SETTINGS from acceptor
qzhuyan
force-pushed
the
dev/william/dyn-acceptors
branch
from
December 10, 2024 16:38
363b40c
to
a5851be
Compare
qzhuyan
force-pushed
the
dev/william/dyn-acceptors
branch
from
December 11, 2024 10:43
dedd273
to
3c5c6ca
Compare
Pull Request Test Coverage Report for Build 12282496592Details
💛 - Coveralls |
qzhuyan
force-pushed
the
dev/william/dyn-acceptors
branch
from
December 11, 2024 19:05
58584ef
to
f21f79c
Compare
replaced with #328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target v0.2.x
server side conn configs are deferred to set at handshake time instead of spawn(accept) time.
New:
async_handshake/2
Support override the conn opts just before the handshake.
quicer_connection:start_acceptor
which supportsproc_start_opts
and deprecating the oldstart_link
for server.quicer_listener:get_conf/2
Breaking changes:
ACCEPTOR
no longer holds the conn settings(opts).this also reduces the memory footprint per conn acceptor and stream acceptor.
async_accept/2
ignore the 2nd arg which was for conn opts.quicer_listener:reload/2
New acceptors now use the new reloaded config.