Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new acceptor reads new listener config #327

Closed
wants to merge 9 commits into from

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Dec 9, 2024

target v0.2.x

server side conn configs are deferred to set at handshake time instead of spawn(accept) time.

New:

  • new async_handshake/2
    Support override the conn opts just before the handshake.
  • New listener scope conf table for handshake the new incoming connections.
  • New quicer_connection:start_acceptor which supports proc_start_opts and deprecating the old start_link for server.
  • New quicer_listener:get_conf/2

Breaking changes:

  • c struct ACCEPTOR no longer holds the conn settings(opts).
    this also reduces the memory footprint per conn acceptor and stream acceptor.
  • async_accept/2 ignore the 2nd arg which was for conn opts.
  • quicer_connection behavior defer the conn settings overrides till handshake.
  • quicer_listener:reload/2
    New acceptors now use the new reloaded config.

@qzhuyan qzhuyan force-pushed the dev/william/dyn-acceptors branch from 44064b0 to 363b40c Compare December 10, 2024 12:33
@qzhuyan qzhuyan force-pushed the dev/william/dyn-acceptors branch from 363b40c to a5851be Compare December 10, 2024 16:38
@qzhuyan qzhuyan force-pushed the dev/william/dyn-acceptors branch from dedd273 to 3c5c6ca Compare December 11, 2024 10:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12282496592

Details

  • 58 of 66 (87.88%) changed or added relevant lines in 5 files are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 86.22%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/quicer_connection.erl 14 15 93.33%
src/quicer_nif.erl 0 1 0.0%
c_src/quicer_connection.c 18 24 75.0%
Files with Coverage Reduction New Missed Lines %
src/quicer_server_conn_callback.erl 1 61.54%
src/quicer.erl 1 90.99%
c_src/quicer_config.c 4 87.67%
src/quicer_connection.erl 10 65.17%
Totals Coverage Status
Change from base Build 12204890233: -0.3%
Covered Lines: 4042
Relevant Lines: 4688

💛 - Coveralls

@qzhuyan qzhuyan force-pushed the dev/william/dyn-acceptors branch from 58584ef to f21f79c Compare December 11, 2024 19:05
@qzhuyan
Copy link
Collaborator Author

qzhuyan commented Dec 12, 2024

replaced with #328

@qzhuyan qzhuyan closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants