-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-7108: Remove unnecessary vendor prefixes #3236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3236 +/- ##
===========================================
+ Coverage 82.48% 82.54% +0.05%
===========================================
Files 157 157
Lines 7247 7241 -6
Branches 1919 1913 -6
===========================================
- Hits 5978 5977 -1
+ Misses 998 993 -5
Partials 271 271 ☔ View full report in Codecov by Sentry. |
@vJIYEv , Please update your branch with the latest develop. |
MikyungKim
reviewed
Jun 20, 2024
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
MikyungKim
reviewed
Jun 25, 2024
MikyungKim
reviewed
Jun 25, 2024
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
MikyungKim
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seunghoh
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Enact has CSS vendor prefixes. Most of them are not required anymore.
Resolution
Considering browser versions we support, I removed unnecessary vendor prefixes.
Additional Considerations
Links
WRQ-7108
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)