Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-7108: Remove unnecessary vendor prefixes #3236

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Conversation

vJIYEv
Copy link
Contributor

@vJIYEv vJIYEv commented May 14, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Enact has CSS vendor prefixes. Most of them are not required anymore.

Resolution

Considering browser versions we support, I removed unnecessary vendor prefixes.

Additional Considerations

Links

WRQ-7108

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.54%. Comparing base (1e444a8) to head (1bd91ec).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3236      +/-   ##
===========================================
+ Coverage    82.48%   82.54%   +0.05%     
===========================================
  Files          157      157              
  Lines         7247     7241       -6     
  Branches      1919     1913       -6     
===========================================
- Hits          5978     5977       -1     
+ Misses         998      993       -5     
  Partials       271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikyungKim
Copy link
Contributor

@vJIYEv , Please update your branch with the latest develop.

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seunghoh seunghoh merged commit 67b7156 into develop Jun 28, 2024
7 checks passed
@seunghoh seunghoh deleted the feature/WRQ-7108 branch June 28, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants