Add proxy configuration to ConnectionPool. #974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #973
HTTPProxy
/AsyncHTTPProxy
/SOCKSProxy
/AsyncSOCKSProxy
classes.This would allow for some refactoring cleanup, eg the following...
https://github.com/encode/httpx/blob/eeb5e3c2a3ff2403ec47b5926715ecd61143d92d/httpx/_transports/default.py#L148-L208
Could become...
It also paves the way for us pushing a
use_system_proxies
config intohttpcore.ConnectionPool
.This would be beneficial as we can then drop the gnarly approach of "system proxies are handled through mounting different connection pool instances" in httpx.
https://github.com/encode/httpx/blob/eeb5e3c2a3ff2403ec47b5926715ecd61143d92d/httpx/_client.py#L658-L692