[Microservice] - Create two microservices #1
Conversation
| <dependency> | ||
| <groupId>io.vertx</groupId> | ||
| <artifactId>vertx-web-client</artifactId> | ||
| <version>3.5.0</version> |
There was a problem hiding this comment.
Using maven dependencyManagement would help for future version upgrade
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.1.5</version> |
There was a problem hiding this comment.
Same as the previous comment
| </testResource> | ||
| </testResources> | ||
|
|
||
| <plugins> |
There was a problem hiding this comment.
We can maybe pull this up in the parent to share the plugin configurations between currency and setting modules
| public class CurrencyMicroservice extends AbstractVerticle { | ||
|
|
||
| public static final String APPLICATION_JSON_CHARSET_UTF_8 = "application/json; charset=utf-8"; | ||
| private static Logger logger = LoggerFactory.getLogger(CurrencyMicroservice.class); |
There was a problem hiding this comment.
logger can be made final
| @Override | ||
| public void start(Future<Void> startFuture) throws Exception { | ||
| super.start(startFuture); | ||
| System.setProperty(LoggerFactory.LOGGER_DELEGATE_FACTORY_CLASS_NAME, SLF4JLogDelegateFactory.class.getName()); |
There was a problem hiding this comment.
We can set this property at the time of running the app or put it in the pom maybe ?
| HttpResponse<Buffer> response = ar.result(); | ||
| logger.info(response.bodyAsString()); | ||
| routingContext.response() | ||
| .setStatusCode(200) |
There was a problem hiding this comment.
Noob question: vertx doesn't provide a StatusCode type ?
There was a problem hiding this comment.
I don't think so. I have to check it
| super.start(startFuture); | ||
| MetricsService metricsService = MetricsService.create(vertx); | ||
| HttpServer server = vertx.createHttpServer(); | ||
| JDBCClient client = JDBCClient.createShared(vertx, new JsonObject() |
There was a problem hiding this comment.
We can externalize this in a configuration file
There was a problem hiding this comment.
Yes. There is a feature in vertx for configuration management
No description provided.