setup.py: use open instead of file #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a pip3 install, the `file` from long_description is not defined. Collecting https://github.com/enix223/modem/archive/refs/heads/multi-protocol.zip (from -r requirements.txt (line 5)) Downloading https://github.com/enix223/modem/archive/refs/heads/multi-protocol.zip \ 184kB 2.4MB/s Complete output from command python setup.py egg_info: Traceback (most recent call last): File "<string>", line 1, in <module> File "/tmp/pip-2kc3v90y-build/setup.py", line 10, in <module> long_description = file('doc/source/about.rst').read(), NameError: name 'file' is not defined
groleo
force-pushed
the
multi-protocol
branch
9 times, most recently
from
b3bc07c
to
d3168f8
Compare
added 2 commits
September 4, 2024 15:47
packages should include the subdirectories/sub-modules. Otherwise, only the files in modem/ will be packaged (without subdirs).
groleo
force-pushed
the
multi-protocol
branch
from
d3168f8
to
9879cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a pip3 install, the
filefrom long_description is not defined.Collecting https://github.com/enix223/modem/archive/refs/heads/multi-protocol.zip (from -r requirements.txt (line 5))
Downloading https://github.com/enix223/modem/archive/refs/heads/multi-protocol.zip
\ 184kB 2.4MB/s
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-2kc3v90y-build/setup.py", line 10, in
long_description = file('doc/source/about.rst').read(),
NameError: name 'file' is not defined