Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MidnightControls Support #120

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

INotDen
Copy link

@INotDen INotDen commented Jan 19, 2024

I think I kind of did it right, but I'm not sure. And about the translations too

@INotDen INotDen closed this Jan 19, 2024
@INotDen INotDen deleted the pull/1.19.4/midnight branch January 19, 2024 15:37
@INotDen INotDen restored the pull/1.19.4/midnight branch January 19, 2024 15:38
@INotDen
Copy link
Author

INotDen commented Jan 19, 2024

Something went wrong with changes

@INotDen INotDen reopened this Jan 19, 2024
@enjarai
Copy link
Owner

enjarai commented Jan 19, 2024

I'd actually removed support for MidnightControls which I used to have in favor of Controlify support, as it's more modern and easier to work with. Is there any particular reason to use Midnight over Controlify?

@INotDen
Copy link
Author

INotDen commented Jan 19, 2024

II'm still a 1.19.4 player, I'm waiting for most mods to be updated, and Controlify is not very good on 1.19.4. Plus, for my case, I have a clone of xbox gamepad, and all applications see it as not necessary (A instead of B, X instead of Y, ...) and surprisingly, MidnightControls sees it perfectly.
I still don't know for myself how much longer I will stay at 1.19.4.
I do not know English, so maybe there are lexical errors in my message.
I decided to do a pull, just in case you're interested.

@INotDen
Copy link
Author

INotDen commented Jan 19, 2024

I think you can leave this as a legacy for 1.19.4 without doing a merge in 1.20, but idk

@enjarai
Copy link
Owner

enjarai commented Jan 20, 2024

Okay yea fair enough, thanks for contributing!

@enjarai enjarai merged commit 54fbee4 into enjarai:1.19.4/next Jan 20, 2024
1 check failed
@INotDen
Copy link
Author

INotDen commented Jan 20, 2024

Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants