Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-1983] Adds new metadata to decoder #39

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Conversation

leonardocustodio
Copy link
Contributor

@leonardocustodio leonardocustodio commented Sep 9, 2024

PR Type

enhancement


Description

  • Updated the productionLatest function in matrix.dart to return the new production version p.v1012.
  • Added a new case for specVersion 1012 in the productionSpec function.
  • Created a new file v1012.dart to define the new production version.

Changes walkthrough 📝

Relevant files
Enhancement
matrix.dart
Update production version to v1012 in matrix.dart               

lib/consts/matrix/matrix.dart

  • Updated productionLatest function to return p.v1012.
  • Added case for specVersion 1012 in productionSpec function.
  • +3/-1     
    v1012.dart
    Add new production version file v1012.dart                             

    lib/consts/matrix/production/v1012.dart

    • Created new file for version v1012.
    +3/-1     
    Additional files (token-limit)
    v1012.dart
    ...                                                                                                           

    lib/consts/matrix/production/v1012.dart

    ...

    +3/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Signed-off-by: Leonardo Custodio <leonardo@custodio.me>
    Signed-off-by: Leonardo Custodio <leonardo@custodio.me>
    @github-actions github-actions bot added the enhancement New feature or request label Sep 9, 2024
    Signed-off-by: Leonardo Custodio <leonardo@custodio.me>
    Copy link

    github-actions bot commented Sep 9, 2024

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Hardcoded Value
    The hardcoded return value p.v1012 in productionLatest function may lead to maintenance issues when new versions are added. Consider using a more dynamic approach or configuration.

    Missing Case
    Ensure that all relevant cases are handled in productionSpec. If specVersion 1012 is added, verify if other versions between 1006 and 1012 should also be included.

    Copy link

    github-actions bot commented Sep 9, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Signed-off-by: Leonardo Custodio <leonardo@custodio.me>
    Signed-off-by: Leonardo Custodio <leonardo@custodio.me>
    Signed-off-by: Leonardo Custodio <leonardo@custodio.me>
    Signed-off-by: Leonardo Custodio <leonardo@custodio.me>
    Signed-off-by: Leonardo Custodio <leonardo@custodio.me>
    @leonardocustodio leonardocustodio changed the title Create v1012.dart [PLA-1983] Adds new metadata to decoder Sep 9, 2024
    @leonardocustodio leonardocustodio merged commit 6afb95f into master Sep 9, 2024
    1 check passed
    @leonardocustodio leonardocustodio deleted the new-metadata branch September 9, 2024 16:12
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Development

    Successfully merging this pull request may close these issues.

    2 participants