Skip to content

Commit

Permalink
Bump tp 4.4.0
Browse files Browse the repository at this point in the history
Signed-off-by: enricocid <enrico2588@gmail.com>
  • Loading branch information
enricocid committed Dec 28, 2020
1 parent 9c9959d commit c03eb6d
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 8 deletions.
10 changes: 6 additions & 4 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,20 @@ If you think you should be listed, don't hesitate to notify me! :)

- [**bullhead**](https://github.com/bullheadandplato) for dialog titles blinking cursor [fixes (https://github.com/enricocid/Music-Player-GO/pull/121) and its equalizer implementation: I learned so much about how an equalizer works

- [**svgrepo.com**](https://www.svgrepo.com/) for the [compact disc](https://www.svgrepo.com/svg/181020/compact-disc-music) icon, opportunely modified (background color).
This work is licensed under a [CC 0](https://creativecommons.org/share-your-work/public-domain/cc0/) license
- [**Ricardo**](https://github.com/RickyM7) for [multiple reports](https://github.com/enricocid/Music-Player-GO/issues/220), other suggestions and testing

- [**Mathieu Aubin**](https://github.com/mathieu-aubin) for the readme's [GIF optimization](https://github.com/mathieu-aubin/tempgif)

- [**svgrepo.com**](https://www.svgrepo.com/) for the [compact disc](https://www.svgrepo.com/svg/181020/compact-disc-music) icon, opportunely modified (background color).
This work is licensed under a [CC 0](https://creativecommons.org/share-your-work/public-domain/cc0/) license


### General credits:

- **Luigi Sforza**, [**Friso Smith**](https://github.com/fwSmit), [**GuinnessX**](https://github.com/GuinnessX) for having reported a critical [issue](https://github.com/enricocid/Music-Player-GO/issues/105) and for debugging

- [**Johnett Mathew**](https://github.com/Johnett) for these [fixes](https://github.com/enricocid/Music-Player-GO/pull/149)

- [**Ricardo**](https://github.com/RickyM7) for [multiple reports](https://github.com/enricocid/Music-Player-GO/issues/220) and other suggestions

- [**seventhsonmizo**](https://github.com/seventhsonmizo) for Android Q [issue](https://github.com/enricocid/Music-Player-GO/issues/110) report and debugging

- [**Jnss98b**](https://github.com/Jnss98b) for helping me to implement [edge-to-edge](https://github.com/enricocid/Music-Player-GO/issues/86) and for having reported/debugged this [issue](https://github.com/enricocid/VectorifyDaHome/issues/17)
Expand All @@ -62,6 +62,8 @@ This work is licensed under a [CC 0](https://creativecommons.org/share-your-work

- **Soyeb Mullick** for having reported this [issue](https://github.com/enricocid/Music-Player-GO/commit/dd1c91d3b62efcd2978a74ef5d64d1615b685c4a)

- **Matt Medeiros** for having reported shuffle issues


### Big thanks to translators:

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- Latest Release -->
<a href="https://github.com/enricocid/Music-Player-GO/releases">
<img alt="GitHub release"
src="https://img.shields.io/static/v1?label=Tag&message=v4.3.9&color=58F5D1">
src="https://img.shields.io/static/v1?label=Tag&message=v4.4.0&color=58F5D1">
</a>
<!-- Minimum SDK -->
<img alt="Minimum SDK" src="https://img.shields.io/static/v1?label=API&message=21&color=32B5ED">
Expand Down
8 changes: 8 additions & 0 deletions fastlane/metadata/android/en-US/changelogs/162.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
- Fix and improve shuffle/queue
Note about songs tab: shuffled music will be queued only if it doesn't exceed 1000 entries
- Fix a crash when removing the app from recents
- Fix a crash due to incorrect audio focus handling
- Fix a crash when trying to filter the last element of the lists
- Minor code review

Special thanks goes to Ricardo and Matt
8 changes: 8 additions & 0 deletions fastlane/metadata/android/it/changelogs/162.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
- Correzioni/migliorie alla mescolazione/coda
Nota sulla tab della canzoni: le canzoni mescolate saranno accodate solo se non sono piรน di 1000
- Corretto un crash alla rimozione della app dai recenti
- Corretto un crash dovuto alla scorretta gestione del focus
- Corretto un crash che accade quando si prova a filtrare l'ultimo elemento di una lista
- Revisione minore del codice

Un ringraziamento speciale va a Ricardo e Matt :)
4 changes: 2 additions & 2 deletions project/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ android {
applicationId "com.iven.musicplayergo"
minSdkVersion 21
targetSdkVersion 30
versionCode 161
versionName "4.3.9"
versionCode 162
versionName "4.4.0"

vectorDrawables.useSupportLibrary true
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,10 @@ class MainActivity : AppCompatActivity(), UIControlInterface {
mMusicViewModel.cancel()
if (isMediaPlayerHolder && !mMediaPlayerHolder.isPlaying && ::mPlayerService.isInitialized && mPlayerService.isRunning && !mMediaPlayerHolder.isSongRestoredFromPrefs) {
mPlayerService.stopForeground(true)
stopService(mBindingIntent)
}
if (sBound) {
unbindService(connection)
stopService(mBindingIntent)
}
}

Expand Down

0 comments on commit c03eb6d

Please sign in to comment.