Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proposer boost reorg e2e test #3

Merged
merged 3 commits into from
Mar 22, 2024
Merged

fix: proposer boost reorg e2e test #3

merged 3 commits into from
Mar 22, 2024

Conversation

twoeths
Copy link

@twoeths twoeths commented Mar 21, 2024 •
edited
Loading

Motivation

  • make sure proposer boost reorg work through e2e test

Description

  • New method isBlockTimely in forkchoice to allow child forkchoice to mark a block as late
  • Put parentBlockRoot to BlockAttributes, make it as chain.getProposerHead() and pass it from api, should not use getHead() during producing block anymore
  • e2e test

link to the main PR: ChainSafe#6298

@ensi321 ensi321 merged commit 07a11d5 into ensi321:proposer-boost-reorg Mar 22, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ensi321 ensi321 ensi321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twoeths @ensi321