Lint on PRs instead of relying on husky (#1629)

.github/workflows/pr.yml

@@ -0,0 +1,13 @@
+name: Lint
+
+on:
+    # Run on every push (this also covers pull requests)
+    push:
+
+jobs:
+    lint:
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v4
+            - run: yarn install
+            - run: yarn lint

.gitignore

@@ -1,52 +1,24 @@
-# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.
-
-# dependencies
+# Node
 node_modules/
-.pnp/
-.pnp.js
-
-# testing
-coverage/
 
-# next.js
+# Next.js
 .next/
 out/
-
-# production
-build/
+.vercel
+.turbo/
 
 # misc
 .DS_Store
-*.pem
+tsconfig.tsbuildinfo
 
 # debug
 npm-debug.log*
 yarn-debug.log*
 yarn-error.log*
 
-tsconfig.tsbuildinfo
-
 # local env files
+.env
 .env.local
 .env.development.local
 .env.test.local
 .env.production.local
-
-# vercel
-.vercel
-
-out_functions
-out_publish
-
-.env
-.idea/
-
-# workbox
-public/sw.js
-public/sw.js.map
-public/worker-*.js
-public/worker-*.js.map
-
-
-# turbo
-**/.turbo/

README.md

@@ -1,6 +1,6 @@
-# ente - simple, safe photo storage
+# Ente – Simple, safe photo storage
 
-**ente** is a cloud storage that provides end-to-end encryption for your data.
+**Ente** is a cloud storage that provides end-to-end encryption for your data.
 
 We have open-source apps across
 [Android](https://github.com/ente-io/photos-app),

apps/accounts/.eslintrc.js

@@ -9,5 +9,5 @@ module.exports = {
         tsconfigRootDir: __dirname,
         project: './tsconfig.json',
     },
-    ignorePatterns: ['.eslintrc.js'],
+    ignorePatterns: ['.eslintrc.js', 'out'],
 };

apps/accounts/src/pages/generate/index.tsx

@@ -5,13 +5,13 @@ import { AppContext } from 'pages/_app';
 import { useContext } from 'react';
 
 export default function Generate() {
-	const appContext = useContext(AppContext);
-	const router = useRouter();
-	return (
-		<GeneratePage
-			appContext={appContext}
-			router={router}
-			appName={APPS.ACCOUNTS}
-		/>
-	);
+    const appContext = useContext(AppContext);
+    const router = useRouter();
+    return (
+        <GeneratePage
+            appContext={appContext}
+            router={router}
+            appName={APPS.ACCOUNTS}
+        />
+    );
 }

apps/accounts/src/pages/signup/index.tsx

@@ -5,13 +5,13 @@ import { AppContext } from 'pages/_app';
 import { useContext } from 'react';
 
 export default function Sigup() {
-	const appContext = useContext(AppContext);
-	const router = useRouter();
-	return (
-		<SignupPage
-			appContext={appContext}
-			router={router}
-			appName={APPS.ACCOUNTS}
-		/>
-	);
+    const appContext = useContext(AppContext);
+    const router = useRouter();
+    return (
+        <SignupPage
+            appContext={appContext}
+            router={router}
+            appName={APPS.ACCOUNTS}
+        />
+    );
 }

apps/auth/.eslintrc.js

@@ -9,5 +9,5 @@ module.exports = {
         tsconfigRootDir: __dirname,
         project: './tsconfig.json',
     },
-    ignorePatterns: ['.eslintrc.js'],
+    ignorePatterns: ['.eslintrc.js', 'out'],
 };

apps/cast/.eslintrc.js

@@ -9,5 +9,5 @@ module.exports = {
         tsconfigRootDir: __dirname,
         project: './tsconfig.json',
     },
-    ignorePatterns: ['.eslintrc.js'],
+    ignorePatterns: ['.eslintrc.js', 'out'],
 };

apps/photos/.eslintrc.js

@@ -9,5 +9,5 @@ module.exports = {
         tsconfigRootDir: __dirname,
         project: './tsconfig.json',
     },
-    ignorePatterns: ['.eslintrc.js'],
+    ignorePatterns: ['.eslintrc.js', 'out', 'thirdparty', 'public'],
 };

apps/photos/src/components/Sidebar/UtilitySection.tsx

@@ -74,10 +74,11 @@ export default function UtilitySection({ closeSidebar }) {
         try {
             const accountsToken = await getAccountsToken();
 
-            window.location.href = `${getAccountsURL()}${ACCOUNTS_PAGES.ACCOUNT_HANDOFF
-                }?package=${CLIENT_PACKAGE_NAMES.get(
-                    APPS.PHOTOS
-                )}&token=${accountsToken}`;
+            window.location.href = `${getAccountsURL()}${
+                ACCOUNTS_PAGES.ACCOUNT_HANDOFF
+            }?package=${CLIENT_PACKAGE_NAMES.get(
+                APPS.PHOTOS
+            )}&token=${accountsToken}`;
         } catch (e) {
             logError(e, 'failed to redirect to accounts page');
         }

package.json

@@ -16,7 +16,6 @@
         "dev:cast": "yarn workspace cast next dev",
         "dev:photos": "yarn workspace photos next dev",
         "albums": "yarn workspace photos albums",
-        "prepare": "husky install",
         "lint": "yarn prettier --check . && yarn workspaces run eslint .",
         "lint-fix": "yarn prettier --write . && yarn workspaces run eslint --fix ."
     },
@@ -39,22 +38,7 @@
         "@typescript-eslint/eslint-plugin": "^7.0.1",
         "@typescript-eslint/parser": "^7.0.1",
         "eslint": "^8.56",
-        "husky": "^7.0.1",
-        "lint-staged": "^13.2.3",
         "prettier": "2.3.2",
         "typescript": "^5.1.3"
-    },
-    "lint-staged": {
-        "apps/**/*.{js,jsx,ts,tsx}": [
-            "eslint --fix",
-            "prettier --write --ignore-unknown"
-        ],
-        "packages/**/*.{js,jsx,ts,tsx}": [
-            "eslint --fix",
-            "prettier --write --ignore-unknown"
-        ],
-        "**/*.{json,css,scss,md,html,yml,yaml}": [
-            "prettier --write --ignore-unknown"
-        ]
     }
 }

packages/accounts/pages/credentials.tsx

@@ -166,8 +166,9 @@ export default function Credentials({
                         isTwoFactorPasskeysEnabled: true,
                     });
                     InMemoryStore.set(MS_KEYS.REDIRECT_URL, PAGES.ROOT);
-                    window.location.href = `${getAccountsURL()}/passkeys/flow?passkeySessionID=${passkeySessionID}&redirect=${window.location.origin
-                        }/passkeys/finish`;
+                    window.location.href = `${getAccountsURL()}/passkeys/flow?passkeySessionID=${passkeySessionID}&redirect=${
+                        window.location.origin
+                    }/passkeys/finish`;
                     return;
                 } else if (twoFactorSessionID) {
                     const sessionKeyAttributes =

packages/accounts/pages/verify.tsx

@@ -81,8 +81,9 @@ export default function VerifyPage({ appContext, router, appName }: PageProps) {
                     isTwoFactorPasskeysEnabled: true,
                 });
                 setIsFirstLogin(true);
-                window.location.href = `${getAccountsURL()}/passkeys/flow?passkeySessionID=${passkeySessionID}&redirect=${window.location.origin
-                    }/passkeys/finish`;
+                window.location.href = `${getAccountsURL()}/passkeys/flow?passkeySessionID=${passkeySessionID}&redirect=${
+                    window.location.origin
+                }/passkeys/finish`;
                 router.push(PAGES.CREDENTIALS);
             } else if (twoFactorSessionID) {
                 setData(LS_KEYS.USER, {

packages/shared/next/next.config.base.js

@@ -1,3 +1,5 @@
+// @ts-check
+
 /**
  * @file Configure the Next.js build
  *
@@ -16,6 +18,9 @@ const gitSHA = cp.execSync('git rev-parse --short HEAD', {
     encoding: 'utf8',
 });
 
+/**
+ * @type {import('next').NextConfig}
+ */
 const nextConfig = {
     /* generate a static export when we run `next build` */
     output: 'export',