Remove the unique items constraint #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out we like having duplicate entries, see HACBS-2394[1] Reference: https://issues.redhat.com/browse/EC-1015 [1] https://issues.redhat.com/browse/HACBS-2394
lcarva
reviewed
Nov 20, 2024
| @@ -90,7 +90,6 @@ data_errors contains error if { | |||
| "required": ["effective_on", "ref"], | |||
| "additionalProperties": false, | |||
| }, | |||
| "uniqueItems": true, | |||
There was a problem hiding this comment.
Remove the with_severity_for_pattern call from below? Or maybe also revert this as part of this PR: #1225
There was a problem hiding this comment.
We should do this as a cleanup, but let's go ahead and merge it as is.
lcarva
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we like having duplicate entries, see HACBS-2394[1]
Reference: https://issues.redhat.com/browse/EC-1015
[1] https://issues.redhat.com/browse/HACBS-2394