Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast start to u16 rather than the SMALL_PRIMES to T #59

Merged
merged 6 commits into from
Oct 19, 2024

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Oct 16, 2024

A very minor optimization. For "small" startting values it's around 5% faster.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.37%. Comparing base (b7158da) to head (a8d672d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   99.37%   99.37%   -0.01%     
==========================================
  Files           9        9              
  Lines        1285     1280       -5     
==========================================
- Hits         1277     1272       -5     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvdplm dvdplm requested a review from fjarri October 17, 2024 07:43
src/hazmat/sieve.rs Outdated Show resolved Hide resolved
src/hazmat/sieve.rs Outdated Show resolved Hide resolved
src/hazmat/sieve.rs Outdated Show resolved Hide resolved
@dvdplm dvdplm requested a review from fjarri October 18, 2024 13:59
@fjarri fjarri merged commit 796002e into master Oct 19, 2024
13 checks passed
@fjarri fjarri deleted the dp-sieve-construction-speedup branch October 19, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants