Add subscription update interceptor to add systemId to update logs #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testower
force-pushed
the
improve/mdc
branch
from
0b87fc1 to
771c79a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Instructions
Summary
The gbfs-loader library has some useful logging, but lack context of feedprovider / system. This PR adds an interceptor to subscriptions so systemId can be added to mapped diagnostics context (mdc).
Depends on entur/gbfs-loader-java#179
Issue
Closes #250. #514 should still be considered as a way to improve handling of those exceptions that are not caught in the library?