Encoding stations.stationArea with polyline #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, just wondering if |
…nAreaPolylineEncodedMultiPolygon
…iPolygon in the test
testower
approved these changes
Aug 28, 2024
testower
requested changes
Aug 28, 2024
|
testower
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue
Closes ETU-51094
Motivation: MultiPolygon data can get quite large for mobile network traffic. Using mapbox polyline can reduce this size by ~90%. This is a lossy compression, but only unnecessary decimal info is lost. Precision has been set to 6 decimals.
How the code works: Add the extra polylineEncodedMultiPolygon field on Station , which is the same as the existing stationArea.coordinates, but where the innermost list of coordinates List<List> is replaced by an encoded String.
Unit tests
Added testStationsPolylineEncodedMultiPolygon
Documentation
Description in graphql schema added.