improved handling if not earliest forested value if provided #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| validateNotNull(optimalForecastedCarbon, "actual Carbon"); | ||
| validateNotNull(savedCarbonPercentage, "saved Carbon"); | ||
| evaluateValidations(); | ||
| } | ||
|
|
||
| public Carbon calculateReduction() { | ||
| if (carbonWithoutOptimization == null) { | ||
| return optimalForecastedCarbon; |
There was a problem hiding this comment.
How can optimalForecastedCarbon be the calculated reduction, if carbonWithoutOptimization is null?
There was a problem hiding this comment.
It was an assumption I made. But yes it should be more transparent. We should add it to the docs.
| final boolean emissionReduction = earliestForecastedValue.getValue() > optimalValue.getValue(); | ||
| return emissionReduction && optimalTime.isInFuture(); | ||
| } | ||
|
|
||
| public double calculateSavedCarbonDelta() { | ||
| if (earliestForecastedValue == null) { | ||
| return 0.0; |
There was a problem hiding this comment.
Same question as previous comment
| return earliestForecastedValue.getValue() - optimalValue.getValue(); | ||
| } | ||
|
|
||
| public double calculateSavedCarbonPercentage() { | ||
| if (earliestForecastedValue == null) { | ||
| return 100; |
There was a problem hiding this comment.
Same question as previous comment
| new Carbon(emissionTimeframe.getOptimalValue().getValue()), | ||
| new Percentage(emissionTimeframe.calculateSavedCarbonPercentage()) | ||
| ); | ||
| } | ||
| // execution is optimal currently | ||
| return new CarbonReduction( | ||
| new Delay(false, 0), | ||
| new Carbon(emissionTimeframe.getEarliestForecastedValue().getValue()), | ||
| new Carbon(emissionTimeframe.getEarliestForecastedValue().getValue()), |
lwluc
force-pushed
the
prepareRelease2_1_5
branch
from
f0de9c1 to
1def252
Compare
lwluc
force-pushed
the
carbon-aware-computing-fix
branch
from
e50c2a5 to
10f3fd4
Compare
maxbehr801
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.