address lint issue

Signed-off-by: Kensei Nakada <handbomusic@gmail.com>

internal/gatewayapi/route.go

@@ -320,28 +320,28 @@ func (t *Translator) processHTTPRouteRule(httpRoute *HTTPRouteContext, ruleIdx i
 			return nil, fmt.Errorf("idle timeout is not supported in envoy gateway")
 		}
 
-		if rule.SessionPersistence.Type == nil || // Cookie-based session persistence is default.
-			*rule.SessionPersistence.Type == gwapiv1.CookieBasedSessionPersistence {
+		switch {
+		case rule.SessionPersistence.Type == nil || // Cookie-based session persistence is default.
+			*rule.SessionPersistence.Type == gwapiv1.CookieBasedSessionPersistence:
 			sessionPersistence = &ir.SessionPersistence{
 				Cookie: &ir.CookieBasedSessionPersistence{
 					Name: *rule.SessionPersistence.SessionName,
 				},
 			}
-
 			if rule.SessionPersistence.AbsoluteTimeout != nil {
 				ttl, err := time.ParseDuration(string(*rule.SessionPersistence.AbsoluteTimeout))
 				if err != nil {
 					return nil, err
 				}
 				sessionPersistence.Cookie.TTL = &metav1.Duration{Duration: ttl}
 			}
-		} else if *rule.SessionPersistence.Type == gwapiv1.HeaderBasedSessionPersistence {
+		case *rule.SessionPersistence.Type == gwapiv1.HeaderBasedSessionPersistence:
 			sessionPersistence = &ir.SessionPersistence{
 				Header: &ir.HeaderBasedSessionPersistence{
 					Name: *rule.SessionPersistence.SessionName,
 				},
 			}
-		} else {
+		default:
 			// Unknown session persistence type is specified.
 			return nil, fmt.Errorf("unknown session persistence type %s", *rule.SessionPersistence.Type)
 		}

test/e2e/testdata/cookie-based-session-persistence.yaml

@@ -24,7 +24,4 @@ spec:
       sessionPersistence:
         sessionName: Session-A
         type: Cookie
-        # Actually, absoluteTimeout is not necessary for Header based session persistence.
-        # But, we have to add it, otherwise the gateway-api validation (mistakenly) rejects it.
-        # https://github.com/kubernetes-sigs/gateway-api/issues/3214
-        absoluteTimeout: 10s 
+        absoluteTimeout: 10s

test/e2e/testdata/header-based-session-persistence.yaml

@@ -27,4 +27,4 @@ spec:
         # Actually, absoluteTimeout is not necessary for Header based session persistence.
         # But, we have to add it, otherwise the gateway-api validation (mistakenly) rejects it.
         # https://github.com/kubernetes-sigs/gateway-api/issues/3214
-        absoluteTimeout: 100s 
+        absoluteTimeout: 10s