DirectResponse

Signed-off-by: zirain <zirain2009@gmail.com>
envoyproxy · May 13, 2024 · 115fdb1 · 115fdb1
1 parent df0af7c
commit 115fdb1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/internal/gatewayapi/route.go b/internal/gatewayapi/route.go
@@ -516,7 +516,8 @@ func (t *Translator) processGRPCRouteRules(grpcRoute *GRPCRouteContext, parentRe
 
 		// If the route has no valid backends then just use a direct response and don't fuss with weighted responses
 		for _, ruleRoute := range ruleRoutes {
-			if ruleRoute.Destination == nil && ruleRoute.Redirect == nil {
+			noValidBackends := ruleRoute.Destination == nil || ruleRoute.Destination.ToBackendWeights().Valid == 0
+			if noValidBackends && ruleRoute.Redirect == nil {
 				ruleRoute.DirectResponse = &ir.DirectResponse{
 					StatusCode: 500,
 				}

diff --git a/internal/gatewayapi/testdata/backendtrafficpolicy-status-conditions.out.yaml b/internal/gatewayapi/testdata/backendtrafficpolicy-status-conditions.out.yaml
@@ -576,6 +576,8 @@ xdsIR:
           name: grpcroute/envoy-gateway/grpcroute-1/rule/0
           settings:
           - weight: 1
+        directResponse:
+          statusCode: 500
         headerMatches:
         - distinct: false
           exact: foo

diff --git a/internal/gatewayapi/testdata/envoyextensionpolicy-status-conditions.out.yaml b/internal/gatewayapi/testdata/envoyextensionpolicy-status-conditions.out.yaml
@@ -575,6 +575,8 @@ xdsIR:
           name: grpcroute/envoy-gateway/grpcroute-1/rule/0
           settings:
           - weight: 1
+        directResponse:
+          statusCode: 500
         headerMatches:
         - distinct: false
           exact: foo

diff --git a/internal/gatewayapi/testdata/securitypolicy-status-conditions.out.yaml b/internal/gatewayapi/testdata/securitypolicy-status-conditions.out.yaml
@@ -447,6 +447,8 @@ xdsIR:
           name: grpcroute/envoy-gateway/grpcroute-1/rule/0
           settings:
           - weight: 1
+        directResponse:
+          statusCode: 500
         headerMatches:
         - distinct: false
           exact: foo