ratelimit: Change rate limit service type to cluster (#1578)

* Allow other service types in the rate limit service Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * make gen-check Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * Revert "make gen-check" This reverts commit 55538c4. Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * Change default service type to Cluster Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * restore default func Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * update test Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> --------- Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
envoyproxy · Jun 27, 2023 · 155f75f · 155f75f
1 parent 4e6786a
commit 155f75f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/internal/infrastructure/kubernetes/ratelimit/resource_provider.go b/internal/infrastructure/kubernetes/ratelimit/resource_provider.go
@@ -55,7 +55,7 @@ func (r *ResourceRender) Service() (*corev1.Service, error) {
 
 	labels := rateLimitLabels()
 
-	serviceSpec := resource.ExpectedServiceSpec(egcfgv1a1.DefaultKubernetesServiceType())
+	serviceSpec := resource.ExpectedServiceSpec(egcfgv1a1.GetKubernetesServiceType(egcfgv1a1.ServiceTypeClusterIP))
 	serviceSpec.Ports = ports
 	serviceSpec.Selector = resource.GetSelector(labels).MatchLabels
 

diff --git a/internal/infrastructure/kubernetes/ratelimit/testdata/envoy-ratelimit-service.yaml b/internal/infrastructure/kubernetes/ratelimit/testdata/envoy-ratelimit-service.yaml
@@ -8,9 +8,8 @@ metadata:
   name: envoy-ratelimit
   namespace: envoy-gateway-system
 spec:
-  type: LoadBalancer
+  type: ClusterIP
   sessionAffinity: None
-  ExternalTrafficPolicy: Local
   ports:
     - name: http
       port: 8081