Skip to content

Commit

Permalink
fix linting
Browse files Browse the repository at this point in the history
Signed-off-by: Guy Daich <guy.daich@sap.com>
  • Loading branch information
guydc committed Feb 22, 2024
1 parent fe58e8f commit 30fcf6b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,11 @@ backendTrafficPolicies:
numRetries: 5
retryOn:
httpStatusCodes:
- 429
- 503
- 429
- 503
triggers:
- connect-failure
- retriable-status-codes
- connect-failure
- retriable-status-codes
perRetry:
timeout: 250ms
backoff:
Expand Down
2 changes: 1 addition & 1 deletion internal/xds/translator/route.go
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ func buildRetryStatusCodes(codes []ir.HTTPStatus) []uint32 {
return ret
}

// buildRetryOn concatenates triggers to a comma-delimited list
// buildRetryOn concatenates triggers to a comma-delimited string.
// An error is returned if a trigger is not in the list of supported values (not likely, due to prior validations).
func buildRetryOn(triggers []ir.TriggerEnum) (string, error) {
if len(triggers) == 0 {
Expand Down
8 changes: 4 additions & 4 deletions internal/xds/translator/testdata/in/xds-ir/retry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ http:
numRetries: 5
retryOn:
httpStatusCodes:
- 429
- 503
- 429
- 503
triggers:
- connect-failure
- retriable-status-codes
- connect-failure
- retriable-status-codes
perRetry:
timeout: 250ms
backoff:
Expand Down

0 comments on commit 30fcf6b

Please sign in to comment.