chore: adjust comment and use pointer for non-manandatory field

Signed-off-by: Ardika Bagus <me@ardikabs.com>

api/v1alpha1/jwt_types.go

@@ -8,9 +8,9 @@ package v1alpha1
 // JWT defines the configuration for JSON Web Token (JWT) authentication.
 type JWT struct {
 
-	// AllowMissing specifies whether a missing JWT is acceptable, but it will fail if an invalid JWT is presented.
-	//
-	AllowMissing bool `json:"allowMissing,omitempty"`
+	// AllowMissing determines whether a missing JWT is acceptable, defaulting to false if not specified.
+	// Note: Even if allowMissing is set to true, JWT authentication will still fail if an invalid JWT is presented.
+	AllowMissing *bool `json:"allowMissing,omitempty"`
 
 	// Providers defines the JSON Web Token (JWT) authentication provider type.
 	// When multiple JWT providers are specified, the JWT is considered valid if

charts/gateway-helm/crds/generated/gateway.envoyproxy.io_securitypolicies.yaml

@@ -423,8 +423,9 @@ spec:
                   authentication.
                 properties:
                   allowMissing:
-                    description: AllowMissing specifies whether a missing JWT is acceptable,
-                      but it will fail if an invalid JWT is presented.
+                    description: |-
+                      AllowMissing determines whether a missing JWT is acceptable, defaulting to false if not specified.
+                      Note: Even if allowMissing is set to true, JWT authentication will still fail if an invalid JWT is presented.
                     type: boolean
                   providers:
                     description: |-

internal/gatewayapi/securitypolicy.go

@@ -527,7 +527,7 @@ func wildcard2regex(wildcard string) string {
 
 func (t *Translator) buildJWT(jwt *egv1a1.JWT) *ir.JWT {
 	return &ir.JWT{
-		AllowMissing: jwt.AllowMissing,
+		AllowMissing: ptr.Deref(jwt.AllowMissing, false),
 		Providers:    jwt.Providers,
 	}
 }

internal/ir/xds.go

@@ -570,7 +570,7 @@ type CORS struct {
 //
 // +k8s:deepcopy-gen=true
 type JWT struct {
-	// AllowMissing specifies whether JWT authentication could be optionally required.
+	// AllowMissing determines whether a missing JWT is acceptable.
 	//
 	AllowMissing bool `json:"allowMissing,omitempty" yaml:"allowMissing,omitempty"`
 

site/content/en/latest/api/extension_types.md

@@ -1514,12 +1514,8 @@ _Appears in:_
 
 | Field | Type | Required | Description |
 | ---   | ---  | ---      | ---         |
-<<<<<<< HEAD
-=======
-| `allowMissing` | _boolean_ |  true  | AllowMissing specifies whether a missing JWT is acceptable, but it will fail if an invalid JWT is presented. |
-| `providers` | _[JWTProvider](#jwtprovider) array_ |  true  | Providers defines the JSON Web Token (JWT) authentication provider type.<br />When multiple JWT providers are specified, the JWT is considered valid if<br />any of the providers successfully validate the JWT. For additional details,<br />see https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/jwt_authn_filter.html. |
->>>>>>> e79687da (feat: add support for optional JWT authentication)
 
+| `allowMissing` | _boolean_ |  true  | AllowMissing determines whether a missing JWT is acceptable, defaulting to false if not specified.<br />Note: Even if allowMissing is set to true, JWT authentication will still fail if an invalid JWT is presented. |
 | `providers` | _[JWTProvider](#jwtprovider) array_ |  true  | Providers defines the JSON Web Token (JWT) authentication provider type.<br />When multiple JWT providers are specified, the JWT is considered valid if<br />any of the providers successfully validate the JWT. For additional details,<br />see https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/jwt_authn_filter.html. |
 
 #### JWTExtractor