Skip to content

Commit

Permalink
translator: set SpawnUpstreamSpan to true (#3102)
Browse files Browse the repository at this point in the history
* translator: set SpawnUpstreamSpan to true

Signed-off-by: zirain <zirain2009@gmail.com>

* update

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
  • Loading branch information
zirain authored Apr 8, 2024
1 parent 5bb7b3f commit 635ebfc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
serviceName: fake-name.fake-ns
randomSampling:
value: 90
spawnUpstreamSpan: true
useRemoteAddress: true
drainType: MODIFY_ONLY
name: first-listener
Expand Down
4 changes: 3 additions & 1 deletion internal/xds/translator/tracing.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
hcm "github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3"
tracingtype "github.com/envoyproxy/go-control-plane/envoy/type/tracing/v3"
xdstype "github.com/envoyproxy/go-control-plane/envoy/type/v3"
"google.golang.org/protobuf/types/known/wrapperspb"
"k8s.io/utils/ptr"

egv1a1 "github.com/envoyproxy/gateway/api/v1alpha1"
Expand Down Expand Up @@ -113,7 +114,8 @@ func buildHCMTracing(tracing *ir.Tracing) (*hcm.HttpConnectionManager_Tracing, e
TypedConfig: ocAny,
},
},
CustomTags: tags,
CustomTags: tags,
SpawnUpstreamSpan: wrapperspb.Bool(true),
}, nil
}

Expand Down

0 comments on commit 635ebfc

Please sign in to comment.