chore: update the function name

envoyproxy · Jul 4, 2024 · 6aa8352 · 6aa8352
1 parent deb57ac
commit 6aa8352
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/internal/gatewayapi/status/gateway.go b/internal/gatewayapi/status/gateway.go
@@ -98,7 +98,7 @@ func UpdateGatewayStatusProgrammedCondition(gw *gwapiv1.Gateway, svc *corev1.Ser
 	}
 
 	// Update the programmed condition.
-	computeGatewayProgrammedCondition(gw, deployment)
+	updateGatewayProgrammedCondition(gw, deployment)
 }
 
 func SetGatewayListenerStatusCondition(gateway *gwapiv1.Gateway, listenerStatusIdx int,
@@ -136,9 +136,9 @@ const (
 	messageFmtProgrammed       = "Address assigned to the Gateway, %d/%d envoy Deployment replicas available"
 )
 
-// computeGatewayProgrammedCondition computes the Gateway Programmed status condition.
+// updateGatewayProgrammedCondition computes the Gateway Programmed status condition.
 // Programmed condition surfaces true when the Envoy Deployment status is ready.
-func computeGatewayProgrammedCondition(gw *gwapiv1.Gateway, deployment *appsv1.Deployment) {
+func updateGatewayProgrammedCondition(gw *gwapiv1.Gateway, deployment *appsv1.Deployment) {
 	if len(gw.Status.Addresses) == 0 {
 		gw.Status.Conditions = MergeConditions(gw.Status.Conditions,
 			newCondition(string(gwapiv1.GatewayConditionProgrammed), metav1.ConditionFalse, string(gwapiv1.GatewayReasonAddressNotAssigned),

diff --git a/internal/gatewayapi/status/gateway_test.go b/internal/gatewayapi/status/gateway_test.go
@@ -187,7 +187,7 @@ func TestUpdateGatewayStatusProgrammedCondition(t *testing.T) {
 	}
 }
 
-func TestGatewayReadyCondition(t *testing.T) {
+func TestUpdateGatewayProgrammedCondition(t *testing.T) {
 	testCases := []struct {
 		name string
 		// serviceAddressNum indicates how many addresses are set in the Gateway status.
@@ -263,7 +263,7 @@ func TestGatewayReadyCondition(t *testing.T) {
 			}
 
 			deployment := &appsv1.Deployment{Status: tc.deploymentStatus}
-			computeGatewayProgrammedCondition(gtw, deployment)
+			updateGatewayProgrammedCondition(gtw, deployment)
 
 			if d := cmp.Diff(tc.expectCondition, gtw.Status.Conditions, cmpopts.IgnoreFields(metav1.Condition{}, "LastTransitionTime")); d != "" {
 				t.Errorf("unexpected condition diff: %s", d)