fix: Run yamllint on generated Install Manifests (#1450)

Run yamllint on generated Install Manifests Fixes: #810 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
envoyproxy · May 26, 2023 · 80db459 · 80db459
1 parent 56edaba
commit 80db459
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml
@@ -18,6 +18,9 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - uses: ./tools/github-actions/setup-deps
+    # Generate the install manifests first so it can checked
+    # for errors while running `make -k lint`
+    - run: make generate-manifests
     - run: make lint-deps
     - run: make -k lint
 

diff --git a/charts/gateway-helm/templates/certgen.yaml b/charts/gateway-helm/templates/certgen.yaml
@@ -29,7 +29,7 @@ spec:
         - name: KUBERNETES_CLUSTER_DOMAIN
           value: {{ .Values.kubernetesClusterDomain }}
         image: {{ .Values.deployment.envoyGateway.image.repository }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }}
-        imagePullPolicy:  {{ .Values.deployment.envoyGateway.imagePullPolicy }}
+        imagePullPolicy: {{ .Values.deployment.envoyGateway.imagePullPolicy }}
         name: envoy-gateway-certgen
       restartPolicy: Never
       securityContext:

diff --git a/tools/linter/yamllint/.yamllint b/tools/linter/yamllint/.yamllint
@@ -1,8 +1,11 @@
 ---
 
 ignore: |
+  # This directory fails checks since many files
+  # are templated. Instead, we run the linter
+  # after running `make generate-manifests` which creates
+  # the Install YAML in bin/
   charts/gateway-helm/
-  bin/install.yaml
 
 rules:
   braces: