fix(chart): set ttlSecondsAfterFinished on certgen job to 30 by default

This is painless workaround for ArgoCD bug: argoproj/argo-cd#6880 Signed-off-by: JuniorJPDJ <git@juniorjpdj.pl>
envoyproxy · Apr 15, 2024 · 98f4b62 · 98f4b62
1 parent 9f00be3
commit 98f4b62
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/charts/gateway-helm/values.tmpl.yaml b/charts/gateway-helm/values.tmpl.yaml
@@ -48,7 +48,7 @@ certgen:
   job:
     annotations: {}
     resources: {}
-    ttlSecondsAfterFinished: 0
+    ttlSecondsAfterFinished: 30
   rbac:
     annotations: {}
     labels: {}
diff --git a/site/content/en/latest/install/api.md b/site/content/en/latest/install/api.md
@@ -26,7 +26,7 @@ The Helm chart for Envoy Gateway
 |-----|------|---------|-------------|
 | certgen.job.annotations | object | `{}` |  |
 | certgen.job.resources | object | `{}` |  |
-| certgen.job.ttlSecondsAfterFinished | int | `0` |  |
+| certgen.job.ttlSecondsAfterFinished | int | `30` |  |
 | certgen.rbac.annotations | object | `{}` |  |
 | certgen.rbac.labels | object | `{}` |  |
 | config.envoyGateway.gateway.controllerName | string | `"gateway.envoyproxy.io/gatewayclass-controller"` |  |

diff --git a/test/helm/default.yaml b/test/helm/default.yaml
@@ -524,4 +524,4 @@ spec:
         runAsNonRoot: true
         runAsUser: 65534
       serviceAccountName: eg-gateway-helm-certgen
-  ttlSecondsAfterFinished: 0
+  ttlSecondsAfterFinished: 30