Skip to content

Commit

Permalink
feat: add detailed description about compression
Browse files Browse the repository at this point in the history
Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>
  • Loading branch information
zufardhiyaulhaq committed Apr 16, 2024
1 parent d26052a commit b66ea38
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion api/v1alpha1/envoyproxy_metric_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ type ProxyOpenTelemetrySink struct {
type ProxyPrometheusProvider struct {
// Disable the Prometheus endpoint.
Disable bool `json:"disable,omitempty"`
// Configure the compression on Prometheus endpoint.
// Configure the compression on Prometheus endpoint. Compression is useful in situations when bandwidth is scarce and large payloads can be effectively compressed at the expense of higher CPU load.
// +optional
Compression *Compression `json:"compression,omitempty"`
}
Original file line number Diff line number Diff line change
Expand Up @@ -6229,6 +6229,9 @@ spec:
properties:
compression:
description: Configure the compression on Prometheus endpoint.
Compression is useful in situations when bandwidth is
scarce and large payloads can be effectively compressed
at the expense of higher CPU load.
properties:
gzip:
description: The configuration for GZIP compressor.
Expand Down
2 changes: 1 addition & 1 deletion site/content/en/latest/api/extension_types.md
Original file line number Diff line number Diff line change
Expand Up @@ -2317,7 +2317,7 @@ _Appears in:_
| Field | Type | Required | Description |
| --- | --- | --- | --- |
| `disable` | _boolean_ | true | Disable the Prometheus endpoint. |
| `compression` | _[Compression](#compression)_ | false | Configure the compression on Prometheus endpoint. |
| `compression` | _[Compression](#compression)_ | false | Configure the compression on Prometheus endpoint. Compression is useful in situations when bandwidth is scarce and large payloads can be effectively compressed at the expense of higher CPU load. |


#### ProxyProtocol
Expand Down

0 comments on commit b66ea38

Please sign in to comment.